-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(neo4j): update neo4j chart #365
feat(neo4j): update neo4j chart #365
Conversation
Update neo4j to the latest chart version supplied by the neo4j organisation. The new chart offers build in support for enterprise and comunity deployments. This also improves security by exposing the podSecurityContext and containerSecurityContext to the user. BREAKING CHANGE: Removal of neo4j-comunity chart and values Change neo4j parameters are now under neo4j.neo4j Rename neo4jPassword to password Rename existingPasswordSecret to passwordFromSecret Change passwordFromSecret expects: neo4j-password and NEO4J_AUTH keys Require PersistentVolume from values Closes: acryldata#364
Thanks! |
Hi @gschuurman. It is exciting to see we are trying to use the new and better Neo4j chart! But since the PR introduces Neo4j 5.x, have you tested if it works well compatibly with the current DataHub (which has been using Neo4j 4.x)? |
@lix-mms I've tested the entire datahub application, and have been running it in production for a couple of weeks. Didn't experience any issues. I also cross validated the used clients in the datahub application. Fortunatly they use a LTS version, which supports multiple versions, including version Neo4J 4.x and 5.x.. |
@gschuurman Thanks for the reply! Great to hear that! Btw, when you use this new Helm chart to deploy the prerequisites, have you experienced that the stateful set for the community and the enterprise are both created, even when we set the edition to "community" in the values? (Following pic shows that after my |
@lix-mms Well, that's one of the reasons I marked it as a breaking change. I would have thought that would also enter into the release notes.
Also please make sure that you update your values file to represent the current state. It might also be possible that the old objects are still existing.
As a last piece of advice, deploy your datahub in a separate namespace, this helps to keep your kubernetes cluster more isolated since connections between namespaces are normally not allowed by default. You can do so by specifying the namespace in the helm command using |
@gschuurman You are completely right! I installed from the Although when providing custom secret for the password, I was asked by Helm to ensure the NEO4J_AUTH exists in the secret and starts with "neo4j" with the following message:
which was not quite intuitive since I expected we might be able to determine for our own root user name. But it is not a show stopper anyway. After the corresponding adjustment, the installation was finally successful with just one community pod. Thank you very much for all the tips! 🙏 |
Btw the document line mentioning the NEO4J_AUTH entry could say that it is expected to be in the secret data rather than in the values yaml so it is a bit more clear to understand. But that's for sure a minor thing. 🙂 |
Update neo4j to the latest chart version supplied by the neo4j organisation. The new chart offers build in support for enterprise and comunity deployments. This also improves security by exposing the podSecurityContext and containerSecurityContext to the user.
BREAKING CHANGE:
Removal of neo4j-comunity chart and values
Change neo4j parameters are now under neo4j.neo4j
Rename neo4jPassword to password
Rename existingPasswordSecret to passwordFromSecret Change passwordFromSecret expects: neo4j-password and NEO4J_AUTH keys Require PersistentVolume from values
Closes: #364
Checklist